Operating System Info
Windows 10
Other OS
No response
OBS Studio Version
Git
OBS Studio Version (Other)
No response
OBS Studio Log URL
https://obsproject.com/logs/KlOpqZ4eWej_F45J
OBS Studio Crash Log URL
No response
Expected Behavior
When I create two image sources, add a filter to first, then copy filter and paste to second source and undo one action, filter should disappears from the second source.
Current Behavior
Looks like undo-redo does not track copy-pasting filters. Filter disappears from the first source.
The same issue appears when you copy-paste filters via right-click context menu on source itself and on "Filters" window of a source. They are technically caused by different code paths, but both issues probably should be adressed together.
Steps to Reproduce
- Create two image sources,
1 and 2
- Add filter to source
1
- Copy filter from source
1 either via right-click context menu on source directly or by opening "Filters" window
- Paste filter to source
2 either via right-click context menu on source directly or by opening "Filters" window
- Press
Crtl+Z
- Notice that filter disappeared from source
1 but remains on 2.
Anything else we should know?
Found this bug while testing #4334 and then discovered it is reproducible on current master as well (dde4d57d726ed6d9e244ffbac093d8ef54e29f44). I can add a fix as a part of that PR or make a separate PR to simplify review and then rebase #4334 on top of that.
Operating System Info
Windows 10
Other OS
No response
OBS Studio Version
Git
OBS Studio Version (Other)
No response
OBS Studio Log URL
https://obsproject.com/logs/KlOpqZ4eWej_F45J
OBS Studio Crash Log URL
No response
Expected Behavior
When I create two image sources, add a filter to first, then copy filter and paste to second source and undo one action, filter should disappears from the second source.
Current Behavior
Looks like undo-redo does not track copy-pasting filters. Filter disappears from the first source.
The same issue appears when you copy-paste filters via right-click context menu on source itself and on "Filters" window of a source. They are technically caused by different code paths, but both issues probably should be adressed together.
Steps to Reproduce
1and211either via right-click context menu on source directly or by opening "Filters" window2either via right-click context menu on source directly or by opening "Filters" windowCrtl+Z1but remains on2.Anything else we should know?
Found this bug while testing #4334 and then discovered it is reproducible on current master as well (
dde4d57d726ed6d9e244ffbac093d8ef54e29f44). I can add a fix as a part of that PR or make a separate PR to simplify review and then rebase #4334 on top of that.