Enable Qt message loop on Linux#447
Merged
Merged
Conversation
This fixes issues cause by building CEF with use_gtk=true which is the default.
Contributor
|
thought we tried this and it didnt work to prevent gtk widgets from murdering cef. |
Contributor
Author
|
If this does not work in the long term, a MainMessageLoop (like MainMessageLoopMultithreadedGtk in cefclient) would need to be implemented to be sure that CEF does not use the GLib default context directly. |
Member
|
Is this change compatible with CEF 103/5060 as well as CEF 126+? |
Contributor
Author
|
Tested with https://cef-builds.spotifycdn.com/cef_binary_103.0.12%2Bg8eb56c7%2Bchromium-103.0.5060.134_linux64_minimal.tar.bz2 (so And the keyboard crash does not occur, and look like it works. Edit: It was mainly tested with CEF 126/127. |
WizardCM
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes obsproject/obs-studio#7146 for normally any CEF build.
This fixes issues cause by building CEF with use_gtk=true which is the default.
Motivation and Context
We built CEF with
use_gtk=falseto avoid having collision between Qt and CEF using the Glib event loop.Using the Qt loop avoids this collision to ever happen.
How Has This Been Tested?
Type (keyboard) in a custom browser dock, a crash should occur with
use_gtk=truewith no Qt loop.Types of changes
Checklist: