avoid illegible ticks when the size of the domain exceeds x times the number of ticks #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
My preference would be to do this at the tickFormat level so that the tick lines are still drawn but only some of them are labeled. For example like so:
tickFormat: ((f, i) => d => i(d) < d ? null : f(d))(d3.utcFormat("%-m/%-d"), d3.utcWeek.every(4)) |
Member
|
Also related to #212, where I’d like to special-case the behavior for ordinal date domains if possible. Though maybe it’s not possible since the dates could be irregularly spaced, so I’m not sure how we’ll know which ticks to label. |
… desired number of ticks
Contributor
Author
|
needs an update with the new tickSpacing option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
http://localhost:8008/?test=mobyDickFaceted has approximately 8 times the number of autoticks (26 letters vs 3.3 autoticks), and it's acceptable because it's single letters (there's even a bit of space left).
With a threshold at 10, and setting the height at the ultimate point before this kicks in, it's really become illegible.
With a threshold at 8, it's just barely begun to be illegible.
With a threshold at 5, it's packed, but still legible.
closes #74