Breakpoint added on double click#237
Merged
mnamici merged 1 commit intoobdasystems:developfrom Dec 6, 2022
Merged
Conversation
mnamici
reviewed
Nov 25, 2022
eddy/core/items/edges/common/base.py
Outdated
| :type hoverEvent: QGraphicsSceneHoverEvent | ||
| """ | ||
| self.setCursor(QtCore.Qt.ArrowCursor) | ||
| self.session.statusBar().clearMessage() |
Collaborator
There was a problem hiding this comment.
Questa la sposterei nelle modifiche sui suggerimenti che è più relativa a quella.
eddy/core/items/edges/common/base.py
Outdated
| Add breakpoint to create right angle when the mouse is double clicked on the text item. | ||
| :type mouseEvent: QGraphicsSceneMouseEvent | ||
| """ | ||
| if not self.breakpoints and self.source.pos().x() != self.target.pos().x() and self.source.pos().y() != self.target.pos().y(): |
Collaborator
There was a problem hiding this comment.
Puoi usare direttamente un confronto del tipo:
self.source.pos() != self.target.pos()in quanto QPoint(F) hanno gli operatori speciali
Collaborator
|
Ultima cosa, metti uno spazio tra i separatori nel commento, es: |
5be4480 to
5f39e6a
Compare
Collaborator
|
Ok grazie, ho fatto squash delle modifiche e sistemato il commento. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.