Skip to content

fix: static upstreams failing validation due to passHostHeader and proxyWebSockets defaults being set incorrectly #3302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tuunit merged 2 commits into from
Jan 17, 2026
Merged

fix: static upstreams failing validation due to passHostHeader and proxyWebSockets defaults being set incorrectly #3302

tuunit merged 2 commits into from
Jan 17, 2026
+60 −23

Conversation

@sourava01
Copy link
Contributor

@sourava01 sourava01 commented Jan 9, 2026 •
edited
Loading

fixes #3301

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@sourava01 sourava01 requested a review from a team as a code owner January 9, 2026 20:37
@github-actions github-actions bot added the go label Jan 9, 2026
@sourava01 sourava01 changed the title fix: static upstream validation error fix: static upstreams failing validation due to passHostHeader and proxyWebSockets defaults being set incorrectly Jan 9, 2026
@sourava01 sourava01 force-pushed the fix/static-upstream-validation-error branch from 31e81b6 to 17f717e Compare January 9, 2026 20:40
@github-actions github-actions bot added the docs label Jan 9, 2026
@sourava01 sourava01 force-pushed the fix/static-upstream-validation-error branch from 0a05522 to 8de6624 Compare January 15, 2026 17:52
@sourava01 sourava01 force-pushed the fix/static-upstream-validation-error branch from 8de6624 to 8376feb Compare January 15, 2026 17:55
@sourava01 sourava01 force-pushed the fix/static-upstream-validation-error branch from 8376feb to a43df33 Compare January 15, 2026 17:57
@tuunit tuunit force-pushed the fix/static-upstream-validation-error branch from a43df33 to 4aeeda4 Compare January 17, 2026 13:35
@github-actions github-actions bot added the tests label Jan 17, 2026
@sourava01 @tuunit
fix: static upstream validation failure
c501911 
Signed-off-by: Sourav Agrawal <souravagr01@gmail.com>
@tuunit tuunit force-pushed the fix/static-upstream-validation-error branch 2 times, most recently from 59f22f1 to 3fcd205 Compare January 17, 2026 13:43
@tuunit
Copy link
Member

tuunit commented Jan 17, 2026

@sourava01 thanks for opening the PR but with the transition to Alpha Config becoming fully ready we want to move to slowly getting rid of relying on nil values in the Options struct fields and therefore each value should always have a sane default value and instead of setting it to nil. I added change on top of yours to adopt the EnsureValues and validation.

@tuunit tuunit force-pushed the fix/static-upstream-validation-error branch from 3fcd205 to 507b0c3 Compare January 17, 2026 13:59
@tuunit
fix: enforcement of defaults compatible with static upstreams
c43bbec 
Signed-off-by: Jan Larwig <jan@larwig.com>
@tuunit tuunit force-pushed the fix/static-upstream-validation-error branch from 507b0c3 to c43bbec Compare January 17, 2026 14:01
@tuunit tuunit merged commit 59f4e42 into oauth2-proxy:master Jan 17, 2026
4 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuunit tuunit tuunit approved these changes

Assignees

No one assigned

Labels

docs go tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Proxy fails to start for static upstreams with validation errors

2 participants

@sourava01 @tuunit