fix: WebSocket proxy to respect PassHostHeader setting #3290
+55
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where WebSocket connections fail when
pass_host_headeris set tofalse. The WebSocket proxy was not respecting this configuration setting, while the regular HTTP proxy does.The fix ensures the WebSocket proxy respects the
PassHostHeaderconfiguration by:passHostHeaderparameter tonewWebSocketReverseProxy()setProxyUpstreamHostHeader()whenPassHostHeader=falseMotivation and Context
When
pass_host_header=falseis configured, regular HTTP requests correctly set theHostheader to the upstream backend URL. However, WebSocket upgrade requests retain the original request host, causing failures when backend services validate theHostheader (e.g., Google Cloud Run, Kubernetes ingress, strict reverse proxies).This inconsistency breaks WebSocket functionality for deployments using:
pass_host_header=falseproxy_websockets=trueHostheaderFixes #3288
How Has This Been Tested?
Tested in production with:
pass_host_header=falseTest results:
Hostheader for both HTTP and WebSocket requestsChecklist: