Skip to content

Conversation

@tuunit
Copy link
Member

@tuunit tuunit commented Oct 28, 2025

Description

Upgrade to latest go1.25.3

How Has This Been Tested?

Regression test, build, linting and unit tests.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@tuunit tuunit requested a review from a team as a code owner October 28, 2025 08:43
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 28, 2025
Signed-off-by: Jan Larwig <jan@larwig.com>
@tuunit tuunit force-pushed the chore/deps-golang-1.25.3 branch from 2124b14 to 371ef8d Compare October 28, 2025 08:44
@github-actions github-actions bot added the docs label Oct 28, 2025
@tuunit tuunit merged commit 8f687e4 into master Oct 28, 2025
9 checks passed
@tuunit tuunit deleted the chore/deps-golang-1.25.3 branch October 28, 2025 08:54
module github.com/oauth2-proxy/oauth2-proxy/v7

go 1.24.6
go 1.25.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, it's best practice to pin to the .0 in the go.mod. I'd like to see this validated by a linter at some point (I have this as a todo for many projects) so will work out a good way to bring this here once I've worked it out there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoelSpeed but when I tested the binary was built with exactly 1.25.0 and not with the latest available patch version 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go 1.25 without the patch .0 might work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh really? 🤔 That's interesting

I've been told by the a Go security team member that this number should not be non-zero. The go.mod is supposed to specify the minimum version, not a specific version

Is some other part of our build tooling tied to this number for any reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants