chore(dep): remove go:generate dependencies from go.mod #2982
+3
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Cc: @tuunit as you authored oauth2-proxy/tools#4 |
66835f7 to
59cad2c
Compare
Remove github.com/oauth2-proxy/tools/reference-gen from dependencies. Instead we are now running it with "go run" with a version suffix. Long version: - github.com/oauth2-proxy/tools/reference-gen is removed from tools/tool/go - in pkg/apis/options/doc.go we now run reference-run with a version suffix (go run package@version) with the version comming from go.mod. - the "//go:generate" line is split in 2 lines (using the -command flag) for readability - "go mod tidy" for cleaning dependencies from go.mod, go.sum Note: we are not upgrading reference-gen here. That will be a further separate change.
59cad2c to
8e951ab
Compare
Contributor
Author
@tuunit Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
github.com/oauth2-proxy/tools/reference-genfrom dependencies. Instead we are now running it with "go run" with a version suffix.Description
github.com/oauth2-proxy/tools/reference-genis removed from tools/tool.gopkg/apis/options/doc.gowe now run reference-run with a version suffix (go run package@version) with the version comming fromgo.mod.//go:generateline is split in 2 lines (using the-commandflag) for readabilitygo mod tidyfor cleaning dependencies fromgo.mod,go.sumNotes:
Motivation and Context
Cleanup dependencies from go.mod which are used only for development.
How Has This Been Tested?
=> no change in code generation
Checklist: