pkg/cookies: use 'Max-Age' instead of 'Expires' for cookie expiration #2697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed. |
Contributor
Author
|
still relevant |
tuunit
previously approved these changes
Sep 15, 2024
Member
|
Apologies this has been sat for so long, we should get this merged. Can you rebase on the latest changes and get the changelog updated to move the entry to the correct section please? |
Contributor
Author
I have rebased the change. |
JoelSpeed
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches to using the 'Max-Age' attribute instead of 'Expires' attribute for cookie expiration.
Motivation and Context
fixes #2696
This change fixes problems with expired cookies in Firefox if time differs between client and server.
How Has This Been Tested?
Checklist: