feat(vulnerabilities): add severity filter to GetVulnerabilitiesQuery#270
feat(vulnerabilities): add severity filter to GetVulnerabilitiesQuery#270
Conversation
…Dto and update service logic refactor(api): change DataPayloadResult.raw type to object and remove unused report interfaces
…ng vulnerabilities by severity levels
Summary of ChangesHello @l1ttps, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the vulnerabilities management interface by adding a severity filter. Users can now easily narrow down their view of vulnerabilities based on their criticality, improving the efficiency of security assessment and response workflows. The changes span across both the frontend, with a new interactive filter component, and the backend, with updated API endpoints and service logic to support the new filtering capability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a severity filter for the vulnerabilities list, enhancing the filtering capabilities. A new SeverityFilter component has been created, and the backend has been updated to support filtering by severity.
My review has identified a high-severity bug in the new SeverityFilter component where a click handler is duplicated, causing the filter selection to not work correctly. I've also pointed out a typo in a filename for better maintainability.
Overall, this is a great feature addition. Addressing these points will make it ready for merge.
| <Checkbox | ||
| checked={isSelected} | ||
| onCheckedChange={() => toggleSeverity(option.value)} | ||
| className="border-muted-foreground" | ||
| /> |
There was a problem hiding this comment.
When the checkbox is clicked, the onClick event bubbles up to the parent div, causing toggleSeverity to be called twice (once from onCheckedChange on the Checkbox and once from onClick on the div). This prevents the checkbox from updating its state correctly. To fix this, you can stop the event propagation from the checkbox to its parent.
<Checkbox
checked={isSelected}
onCheckedChange={() => toggleSeverity(option.value)}
onClick={(e) => e.stopPropagation()}
className="border-muted-foreground"
/>
| import DetailSheet from './components/detail-sheet'; | ||
| import { SeverityFilter } from './components/severity-filter'; | ||
| import { StatusFilter } from './components/status-filter'; | ||
| import { vulnerabilityColumns } from './vulnerablity-columns'; |
There was a problem hiding this comment.
There's a typo in this file's name. For consistency and better maintainability, it should be renamed from list-vulnerabilitys.tsx to list-vulnerabilities.tsx.
No description provided.