Skip to content

build: test against Go 1.25 #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamietanna merged 2 commits into from
Aug 20, 2025
Merged

build: test against Go 1.25 #2056

jamietanna merged 2 commits into from
Aug 20, 2025

Conversation

@jamietanna
Copy link
Member

@jamietanna jamietanna commented Aug 13, 2025

No description provided.

@jamietanna jamietanna requested a review from a team as a code owner August 13, 2025 08:53
@kusari-inspector
Copy link

kusari-inspector bot commented Aug 13, 2025 •
edited
Loading

Kusari Analysis Results

Analysis for commit: a903853, performed at: 2025-08-13T08:53:11Z

• @kusari-inspector rerun - Trigger a re-analysis of this PR

• @kusari-inspector feedback [your message] - Send feedback to our AI and team

Recommendation

✅ PROCEED with this Pull Request

Summary

✅ No Flagged Issues Detected

All values appear to be within acceptable risk parameters.

No pinned version dependency changes, code issues or exposed secrets detected!

Found this helpful? Give it a 👍 or 👎 reaction!

@jamietanna
Copy link
Member Author

jamietanna commented Aug 13, 2025

Hmm, given these failures:

# golang.org/x/tools/internal/tokeninternal
Error: ../../../../go/pkg/mod/golang.org/x/tools@v0.21.1-0.20240508182429-e35e4ccd0d2d/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)

This may be blocked by #1641 and / the /x/ packages needing an update, but as it pulls https://github.com/oapi-codegen/oapi-codegen/pull/1972 it then needs to bump the go` directive, which we prefer to avoid where possible

@jamietanna
Copy link
Member Author

jamietanna commented Aug 16, 2025

golang/go#74462

Jamie Tanna added 2 commits August 20, 2025 10:21
fix(deps): update module golang.org/x/tools to v0.25.1
4985062 
As noted in golang/go#74462, this is a
required bump needed to allow building Go 1.25 on older versions of Go.
build: test against Go 1.25
a903853
@kusari-inspector
Copy link

kusari-inspector bot commented Aug 20, 2025

Kusari PR Analysis rerun based on - a903853 performed at: 2025-08-20T09:22:05Z - link to updated analysis

@jamietanna jamietanna merged commit bdc4edc into main Aug 20, 2025
43 checks passed
@jamietanna jamietanna deleted the build/125 branch August 20, 2025 09:25
@jamietanna jamietanna added the chore Any maintenance tasks that are regular, not as important to call out in the changelog label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore Any maintenance tasks that are regular, not as important to call out in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamietanna