fix: ensure we pre-import nullable
#1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a report (via Twitter) that `nullable` wasn't getting generated for them. It appears we may not be seeing the issue due to us already having an import of `nullable`, and therefore when `goimports` runs, it knows the library is here. Instead, we can make sure that we pre-import it for folks who don't already have it in their `go.mod`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a report (via Twitter) that
nullablewasn't gettinggenerated for them.
It appears we may not be seeing the issue due to us already having an
import of
nullable, and therefore whengoimportsruns, it knows thelibrary is here.
Instead, we can make sure that we pre-import it for folks who don't
already have it in their
go.mods.