Update styled parameter binding to include 'Required' attribute #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code across multiple package templates was updated to include the 'Required' attribute when binding styled parameters. This change will ensure that mandatory parameters are appropriately handled during the binding process, preventing potential issues with parameter handling at runtime. This adjustment was made across several packages, including 'gin', 'echo', 'fiber', 'iris', 'gorilla', 'chi' for uniform behavior across all packages.
e6db907 to
87ae907
Compare
Member
|
Thanks! This is a follow-up to oapi-codegen/runtime#19. Just confirming internally about when we'll release the new |
jamietanna
requested changes
Nov 14, 2023
Member
jamietanna
left a comment
There was a problem hiding this comment.
Will require a bump of the runtime package, once released 👍
This was referenced Nov 14, 2023
Member
|
https://github.com/oapi-codegen/runtime/releases/tag/v1.1.0 is now released, mind updating to follow the new structure? |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code across multiple package templates was updated to include the 'Required' attribute when binding styled parameters. This change will ensure that mandatory parameters are appropriately handled during the binding process, preventing potential issues with parameter handling at runtime. This adjustment was made across several packages, including 'gin', 'echo', 'fiber', 'iris', 'gorilla', 'chi' for uniform behavior across all packages.