Skip to content

Fix: Use of AnyOf inline generates struct type names starting with a number #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daleef-rahman wants to merge 0 commits into from
Closed

Fix: Use of AnyOf inline generates struct type names starting with a number #1136

daleef-rahman wants to merge 0 commits into from
+0 −0

Conversation

@daleef-rahman
Copy link
Contributor

@daleef-rahman daleef-rahman commented Jul 5, 2023

#1121 reports that use of AnyOf inline generates invalid go code for client (struct type names starting with a number).
This PR fixes 2 issues:

  1. When status code is the first element of path, PathToTypeName function will generate type name starting with a number
  2. When a property have UnionElements and we use PathToTypeName to generate a reference type, we are not creating the corresponding struct for it

Closes #1121

@deepmap-marcinr
Copy link
Contributor

deepmap-marcinr commented Jul 28, 2023

I'm happy to merge this.

Please rebase, then run go generate ./... from the top level, and fix that linter error.

@daleef-rahman
Copy link
Contributor Author

daleef-rahman commented Aug 2, 2023

I'm happy to merge this.

Please rebase, then run go generate ./... from the top level, and fix that linter error.

Thank you for your message. Will get this done today.

@daleef-rahman daleef-rahman deleted the defect/anyof-1121 branch August 4, 2023 19:08
@daleef-rahman daleef-rahman restored the defect/anyof-1121 branch August 4, 2023 19:09
@daleef-rahman daleef-rahman deleted the defect/anyof-1121 branch August 4, 2023 19:09
@daleef-rahman daleef-rahman mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use of AnyOf generates struct type names starting with a number

2 participants

@daleef-rahman @deepmap-marcinr