Skip to content

Fix: Correctly parse yEnc headers with combined name/ypart lines#571

Merged
dnzbk merged 3 commits intodevelopfrom
fix/yenc
May 23, 2025
Merged

Fix: Correctly parse yEnc headers with combined name/ypart lines#571
dnzbk merged 3 commits intodevelopfrom
fix/yenc

Conversation

@dnzbk
Copy link
Copy Markdown
Collaborator

@dnzbk dnzbk commented May 23, 2025

Description

  • Handles the edge case where =ypart is on the same line as the filename
  • Added unit tests for the Decoder class to improve code coverage

Testing

  • Windows 11
  • macOS Ventura

@dnzbk dnzbk requested review from luckedea and phnzb May 23, 2025 07:44
@dnzbk dnzbk merged commit 61fe70e into develop May 23, 2025
9 checks passed
@dnzbk dnzbk deleted the fix/yenc branch May 23, 2025 10:57
@Safihre
Copy link
Copy Markdown

Safihre commented May 25, 2025

This has occurred in the wild? I would almost have expected the new servers to not allow posting data broken like this.

@luckedea
Copy link
Copy Markdown
Member

luckedea commented May 25, 2025

This has occurred in the wild? I would almost have expected the new servers to not allow posting data broken like this.

@Safihre
Yes, reported in discord, confirmed with some files and indexers.

@dnzbk
Copy link
Copy Markdown
Collaborator Author

dnzbk commented May 25, 2025

I would almost have expected the new servers to not allow posting data broken like this.

Me neither. I can send you the NZB if you’d like to test or investigate it.

@Safihre
Copy link
Copy Markdown

Safihre commented May 25, 2025

I hope they just improve their ways after they get reports of users failing to get their releases.

@Safihre
Copy link
Copy Markdown

Safihre commented May 25, 2025

But if you could send me the nzb, I can at least double check how Sab behaves :)
Since yenc decoding for us is also written in C, I hope it doesn't segfault 🫣
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants