Suppress some "-Wunused-parameter" compiler warnings by boechat107 · Pull Request #561 · nzbgetcom/nzbget

boechat107 · 2025-05-06T09:37:32Z

Description

This PR adds the attribute [[maybe_unused]] (available since C++17) to parameters of virtual functions and parameters that are used only for WIN32.

Here are some compiler warning examples:

==== Util.cpp ====

/home/boechat/Code/Opensource/nzbget/daemon/util/Util.cpp: In static member function ‘static void Util::SetStandByMode(bool)’:
/home/boechat/Code/Opensource/nzbget/daemon/util/Util.cpp:855:32: warning: unused parameter ‘standBy’ [-Wunused-parameter]
  855 | void Util::SetStandByMode(bool standBy)
      |                           ~~~~~^~~~~~~

==== FileSystem.cpp & ScriptController.h ====

/home/boechat/Code/Opensource/nzbget/daemon/util/FileSystem.cpp: In static member function ‘static bool FileSystem::AllocateFile(const char*, int64, bool, CString&)’:
/home/boechat/Code/Opensource/nzbget/daemon/util/FileSystem.cpp:303:70: warning: unused parameter ‘sparse’ [-Wunused-parameter]
  303 | bool FileSystem::AllocateFile(const char* filename, int64 size, bool sparse, CString& errmsg)
      |                                                                 ~~~~~^~~~~~
In file included from /home/boechat/Code/Opensource/nzbget/daemon/main/Maintenance.h:25,
                 from /home/boechat/Code/Opensource/nzbget/daemon/remote/XmlRpc.cpp:32:
/home/boechat/Code/Opensource/nzbget/daemon/util/ScriptController.h: In member function ‘virtual const char* ScriptController::GetOptValue(const char*, const char*)’:
/home/boechat/Code/Opensource/nzbget/daemon/util/ScriptController.h:82:53: warning: unused parameter ‘name’ [-Wunused-parameter]
   82 |         virtual const char* GetOptValue(const char* name, const char* value) { return value; }
      |                                         ~~~~~~~~~~~~^~~~
/home/boechat/Code/Opensource/nzbget/daemon/util/FileSystem.cpp: In static member function ‘static CString FileSystem::MakeExtendedPath(const char*, bool)’:
/home/boechat/Code/Opensource/nzbget/daemon/util/FileSystem.cpp:1171:61: warning: unused parameter ‘force’ [-Wunused-parameter]
 1171 | CString FileSystem::MakeExtendedPath(const char* path, bool force)
      |                                                        ~~~~~^~~~~

==== Options.h ====

/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h: In member function ‘virtual void Options::Extender::AddFeed(int, const char*, const char*, int, const char*, bool, bool, const char*, int, const char*)’:
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:181:42: warning: unused parameter ‘id’ [-Wunused-parameter]
  181 |                 virtual void AddFeed(int id, const char* name, const char* url, int interval,
      |                                      ~~~~^~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:181:58: warning: unused parameter ‘name’ [-Wunused-parameter]
  181 |                 virtual void AddFeed(int id, const char* name, const char* url, int interval,
      |                                              ~~~~~~~~~~~~^~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:181:76: warning: unused parameter ‘url’ [-Wunused-parameter]
  181 |                 virtual void AddFeed(int id, const char* name, const char* url, int interval,
      |                                                                ~~~~~~~~~~~~^~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:181:85: warning: unused parameter ‘interval’ [-Wunused-parameter]
  181 |                 virtual void AddFeed(int id, const char* name, const char* url, int interval,
      |                                                                                 ~~~~^~~~~~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:182:37: warning: unused parameter ‘filter’ [-Wunused-parameter]
  182 |                         const char* filter, bool backlog, bool pauseNzb, const char* category,
      |                         ~~~~~~~~~~~~^~~~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:182:50: warning: unused parameter ‘backlog’ [-Wunused-parameter]
  182 |                         const char* filter, bool backlog, bool pauseNzb, const char* category,
      |                                             ~~~~~^~~~~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:182:64: warning: unused parameter ‘pauseNzb’ [-Wunused-parameter]
  182 |                         const char* filter, bool backlog, bool pauseNzb, const char* category,
      |                                                           ~~~~~^~~~~~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:182:86: warning: unused parameter ‘category’ [-Wunused-parameter]
  182 |                         const char* filter, bool backlog, bool pauseNzb, const char* category,
      |                                                                          ~~~~~~~~~~~~^~~~~~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:183:29: warning: unused parameter ‘priority’ [-Wunused-parameter]
  183 |                         int priority, const char* extensions) {}
      |                         ~~~~^~~~~~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:183:51: warning: unused parameter ‘extensions’ [-Wunused-parameter]
  183 |                         int priority, const char* extensions) {}
      |                                       ~~~~~~~~~~~~^~~~~~~~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h: In member function ‘virtual void Options::Extender::AddTask(int, int, int, int, Options::ESchedulerCommand, const char*)’:
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:184:42: warning: unused parameter ‘id’ [-Wunused-parameter]
  184 |                 virtual void AddTask(int id, int hours, int minutes, int weekDaysBits, ESchedulerCommand command,
      |                                      ~~~~^~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:184:50: warning: unused parameter ‘hours’ [-Wunused-parameter]
  184 |                 virtual void AddTask(int id, int hours, int minutes, int weekDaysBits, ESchedulerCommand command,
      |                                              ~~~~^~~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:184:61: warning: unused parameter ‘minutes’ [-Wunused-parameter]
  184 |                 virtual void AddTask(int id, int hours, int minutes, int weekDaysBits, ESchedulerCommand command,
      |                                                         ~~~~^~~~~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:184:74: warning: unused parameter ‘weekDaysBits’ [-Wunused-parameter]
  184 |                 virtual void AddTask(int id, int hours, int minutes, int weekDaysBits, ESchedulerCommand command,
      |                                                                      ~~~~^~~~~~~~~~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:184:106: warning: unused parameter ‘command’ [-Wunused-parameter]
  184 |                 virtual void AddTask(int id, int hours, int minutes, int weekDaysBits, ESchedulerCommand command,
      |                                                                                        ~~~~~~~~~~~~~~~~~~^~~~~~~
/home/boechat/Code/Opensource/nzbget/daemon/main/Options.h:185:37: warning: unused parameter ‘param’ [-Wunused-parameter]
  185 |                         const char* param) {}
      |                         ~~~~~~~~~~~~^~~~~

dnzbk

Thank you.

boechat107 added 4 commits May 5, 2025 14:49

Suppress compiler warnings about unused parameters in "Options.h"

b74f8cb

Suppress "Wunused-paramenter" compiler warnings of virtual functions

92284be

Suppress compiler warnings for parameters used for WIN32 only

ea72e1d

Fix indentation

da7d97c

dnzbk self-requested a review May 6, 2025 09:43

dnzbk approved these changes May 6, 2025

View reviewed changes

dnzbk merged commit 8c02fed into nzbgetcom:develop May 6, 2025
9 checks passed

dnzbk mentioned this pull request May 12, 2025

Release v25.0 #565

Merged

BrewTestBot mentioned this pull request May 12, 2025

nzbget 25.0 Homebrew/homebrew-core#223164

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suppress some "-Wunused-parameter" compiler warnings#561

Suppress some "-Wunused-parameter" compiler warnings#561
dnzbk merged 4 commits intonzbgetcom:developfrom
boechat107:unused-warnings-options

boechat107 commented May 6, 2025

Uh oh!

dnzbk left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

boechat107 commented May 6, 2025

Description

Uh oh!

dnzbk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants