Skip to content

Build fails with -DDISABLE_PARCHECK=yes -DENABLE_TESTS=true (attempts to build ParCheckerTest.cpp and ParRenamerTest.cpp) #480

@sbraz

Description

@sbraz

Is there already an issue for your problem?

  • I have checked older issues, open and closed

NZBGet Version

v24.5-stable

Platform

All

Environment

Gentoo ~amd64

Current Behavior

The build fails with e.g.

/var/tmp/portage/net-nntp/nzbget-24.5/work/nzbget-24.5/tests/postprocess/ParRenamerTest.cpp:37:1: error: expected class-name before ‘{’ token                                                                      
   37 | {                                                                                                                                                                                                          
      | ^                                                                                                                                                                                                          
/var/tmp/portage/net-nntp/nzbget-24.5/work/nzbget-24.5/tests/postprocess/ParRenamerTest.cpp: In constructor ‘ParRenamerMock::ParRenamerMock(std::string, std::string)’:                                            
/var/tmp/portage/net-nntp/nzbget-24.5/work/nzbget-24.5/tests/postprocess/ParRenamerTest.cpp:55:9: error: ‘SetDestDir’ was not declared in this scope                                                               
   55 |         SetDestDir(m_workingDir.c_str());                                                                                                                                                                  
      |         ^~~~~~~~~~                                                                                                                                                                                         
/var/tmp/portage/net-nntp/nzbget-24.5/work/nzbget-24.5/tests/postprocess/ParRenamerTest.cpp: In member function ‘void ParRenamerMock::Execute()’:                                                                  
/var/tmp/portage/net-nntp/nzbget-24.5/work/nzbget-24.5/tests/postprocess/ParRenamerTest.cpp:63:9: error: ‘ParRenamer’ has not been declared                                                                        
   63 |         ParRenamer::Execute();                                                                                                                                                                             
      |         ^~~~~~~~~~                                                                                                                                                                                         
In file included from /usr/include/boost/test/test_tools.hpp:45,                                                                                                                                                   
                 from /usr/include/boost/test/unit_test.hpp:18,                                                                                                                                                    
                 from /var/tmp/portage/net-nntp/nzbget-24.5/work/nzbget-24.5/tests/postprocess/ParRenamerTest.cpp:24:                                                                                              

Expected Behavior

It should work.

Steps To Reproduce

  1. Run cmake -DDISABLE_PARCHECK=true -DENABLE_TESTS=true
  2. Run make

Logs

No response

Extra information

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions