Make display of onboarding page conditional.#2485
Make display of onboarding page conditional.#2485bengotow merged 1 commit intonylas:masterfrom jonasws:master
Conversation
When running against a custom Sync Engine, viewing the onboarding page on startup does not make much sense. This here adds code that checks for the `env` of the Nylas config and skips the onboarding if it is `local` or `custom`.
|
Has this been released to production then? (sorry I'm still getting used to how this Github process works) |
|
No, the pull request has not been merged. |
|
How do we get someone to merge it? :) |
|
Hey folks! Has anyone tried to run the app with this patch applied? I think it'll still be necessary to populate the Otherwise when the app runs, exceptions will be thrown as you move through the interface (because the UI queries for the user identity) and also when N1 tries to make any API request (because of safety checks like this: https://github.com/nylas/N1/blob/stable/src/flux/nylas-api-request.es6#L37). |
|
@bengotow I have used this patch since I submitted it and it works fine. I did try to analyze the code in order to see if there were other places in the code that were relying on the N1 ID feature, but I couldn't find any at the time. |
|
Cool! Can you double check that your previous credentials aren't saved in the keychain or config.json? It might be reading you old access token and config and continuing to work. (if you logged into N1 before creating this patch). On a Mac you can launch Keychain Access and the N1 token should appear in the "All Items" list. There are entries for each of your email accounts and also one that says "Account: Nylas Account" which is your N1 Identity token:
|
|
I double checked, and the tokens present in my GNOME keyring were for my email accounts (Sync engine). None for the Nylas ID account. So all should be good! |
|
@bengotow any plan on when to merge this? Seems it would help a lot of people. At least people are asking questions about this on Slack. |
|
I can confirm that this change works (under current Ubuntu with KDE) |
|
Works fine for me too (Manjaro/xfce). Thank you for the PR 👍 |
|
Hey folks—thanks for the feedback. I'm going to go ahead and merge this, but we're working on a broader patch for users who are hosting the sync engine themselves. We never intended for |
When running against a custom Sync Engine, viewing the onboarding page
on startup does not make much sense. This here adds code that checks for
the
envof the Nylas config and skips the onboarding if it islocalor
custom.This fixes #2468.