Resolve an issue with setting permissions on IIS Logs folder#339
Merged
david-poindexter merged 1 commit intonvisionative:developfrom Oct 27, 2021
Merged
Conversation
|
@david-poindexter, Hi David, excuse my ignorance, is this something we need to fix somewhere or are you updating you solution to address the issue. It's a bit 'techno-speak' :-( |
Member
Author
|
@dhassall the issue is technically already addressed, but we just need to publish a new release so you can download and install it. We should have the new release published soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #334
Resolves #337
There was evidently a long-standing bug here caused by trying to set permissions on the IIS logs folder using the
NT Service\MSSQLSERVERaccount instead of theIIS AppPool\...account. This PR not only resolves this issue but also adds more useful information to the logging to make it clearer what is actually happening when setting folder permissions.