Skip to content

Change button text#312

Merged
david-poindexter merged 2 commits intonvisionative:developfrom
EPTamminga:develop
Dec 1, 2020
Merged

Change button text#312
david-poindexter merged 2 commits intonvisionative:developfrom
EPTamminga:develop

Conversation

@EPTamminga
Copy link
Copy Markdown
Contributor

@EPTamminga EPTamminga commented Nov 30, 2020

Resolves #311

Update ViewExistingSites.Designer.cs
Copy link
Copy Markdown
Collaborator

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it could we rename metroButton2 to btnClose or some such ? Other than that, I am good with this change either way.

@david-poindexter david-poindexter added this to the 2.1.1 milestone Dec 1, 2020
@david-poindexter
Copy link
Copy Markdown
Member

While we are at it could we rename metroButton2 to btnClose or some such ? Other than that, I am good with this change either way.

@valadas I agree with the recommended change. Let's go ahead and merge this PR and we can create a new PR for the control name change.

@EPTamminga I am also going to update your PR description so #311 will be auto-closed upon merging this PR. Thanks for your contribution! 🎉

@david-poindexter david-poindexter merged commit 41494e3 into nvisionative:develop Dec 1, 2020
@EPTamminga
Copy link
Copy Markdown
Contributor Author

@david-poindexter: it was a massive change :-)

(While I made the issue, my idea was to solve it in the same round)

@david-poindexter
Copy link
Copy Markdown
Member

Thanks @EPTamminga - no worries. A change to the control name would need to be built and tested locally anyway. So it was just as easy to split it up and get the cosmetics rolled in via this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change text Cancel to Close

3 participants