Skip to content

refactor: reach the master#93

Merged
delphinus merged 56 commits intomasterfrom
refactor-again
Jun 10, 2023
Merged

refactor: reach the master#93
delphinus merged 56 commits intomasterfrom
refactor-again

Conversation

@delphinus
Copy link
Copy Markdown
Member

@delphinus delphinus commented Apr 9, 2023 •
edited
Loading

This adds commits from the master into the refactor branch #35 . Needs more tests to merge.

TODO

  • db_root option does not work.
  • Type annotations have many errors.
    • I will fix this later in another PR.
  • auto_validate works validly?

Here is notes from #35 below. I will refactor more in another PR.

Changes:

  • Use sql.nvim new api to make data layer more readable.
  • Move some files out telescope/_extentions/
  • Create algo.lua: to be the place to store calculation or algorithms (idk feels wrong now)
  • general refactoring

kkharji and others added 30 commits August 23, 2021 07:13
@kkharji
refactor(db): use new sql.nvim api
7fe1594
@kkharji
refactor(*): create const, algo and add more util
f463ed9
@kkharji
refactor(picker): try to cleanup and make it easy to read
70d59a4 
FIXME: it seems that I didn't refactor the entry maker right.
@kkharji
refactor(*): move util to lua/frecency
fa335af
@kkharji
misc(db): flag possible bug
6a65046
@kkharji
refactor(db): reflect changes introduced in kkharji/sqlite.lua#96
ea7ea44
@kkharji
refactor(db): move set_config to frecency.lua
1f7a236
@kkharji
new(db): ignore term and octo paths
b340f45 
This may possibly fix the issue with entry.count being nil.
@kkharji
misc(picker): move health out of export
a5aea73
@kkharji
refactor(util)
a3b6302
@kkharji
refactor(db): general
544553e
@kkharji
misc(*): nothing major
caaa576
@kkharji
refactor(db): abbreviate table namespace access
23af141
@kkharji
refactor(picker): working-ish
1ed6727
@kkharji
fix(*): general
cd7a8e5
@kkharji
refactor(picker): move fd function to the end of the file
5e89b9d
@kkharji
refactor(*): remove the need for db.init
3c75536
@kkharji
new(db): use foreign keys
3d3baa1
@kkharji
sync with sqlite.lua@#105
e2db131
@delphinus
feat: add settings for StyLua
803c249
@delphinus
fix: detect the valid module in healthcheck
51a4526 
See #65
@delphinus
style: fix by StyLua
8f62401
@delphinus
fix: detect CWD tag to cut paths
92c6a45 
See #66
@delphinus
fix: show icon before directory
36fc33e 
See #67
@delphinus
fix: deal with show_filter_column option validly
5e3b02a
@MunifTanjim @delphinus
feat: support opts.workspace (#68)
b7f8d95
@premell @delphinus
doc(readme): update config example (#33)
c78f4c6 
remove comma causing error.
@IndianBoy42 @kkharji @delphinus
doc(readme): fix packer install instructions (#34)
775f781 
Co-authored-by: tami5 <65782666+tami5@users.noreply.github.com>
@kkharji @delphinus
doc: follow sqlite new release (#40)
7bc3fda 
* refactor(sql_wrapper): follow sqlite new release

* update readme
@delphinus
refactor: follow telescope's interface changes
e61295c 
See #46
@delphinus delphinus mentioned this pull request Apr 11, 2023
Closed
5 tasks
@delphinus delphinus marked this pull request as ready for review April 13, 2023 09:39
@delphinus
Copy link
Copy Markdown
Member Author

delphinus commented Apr 13, 2023

Seems working now.

@delphinus
fix: return a valid entry with get()
29c526b 
It have used where() to get the entry and where() uses get() to fetch
from DB. But this table has been customized by overwriting get(), so it
has a bug to return the same entry every time it calls. This fixes it.
@delphinus
refactor: get the buffer name explicitly
9caec1f
@delphinus
fix: clean up logic to validate DB
17ff5cd
@sunjon
Copy link
Copy Markdown
Collaborator

sunjon commented Apr 16, 2023

Hi. I'm hopefully going to have time to show the plugins I wrote a bit more love now.
Thanks for all the work - this looks great!. Give me a couple of days to try read through the changes and try it out.

@delphinus
Copy link
Copy Markdown
Member Author

delphinus commented Apr 25, 2023 •
edited
Loading

Now this takes over #35, so changes the target to master.

@delphinus delphinus changed the base branch from refactor to master April 25, 2023 09:58
@delphinus
Copy link
Copy Markdown
Member Author

delphinus commented Jun 10, 2023

I have been dog-fooding long time, and it seems safe to merge.

1 similar comment
@delphinus
Copy link
Copy Markdown
Member Author

delphinus commented Jun 10, 2023

I have been dog-fooding long time, and it seems safe to merge.

@delphinus
Copy link
Copy Markdown
Member Author

delphinus commented Jun 10, 2023

I will merge this. Another refactoring is needed.

1 similar comment
@delphinus
Copy link
Copy Markdown
Member Author

delphinus commented Jun 10, 2023

I will merge this. Another refactoring is needed.

@delphinus delphinus merged commit 3f709af into master Jun 10, 2023
@delphinus delphinus deleted the refactor-again branch June 10, 2023 05:37
@delphinus delphinus mentioned this pull request Jul 29, 2023
Closed
@delphinus delphinus mentioned this pull request Aug 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@delphinus @sunjon @kkharji @MunifTanjim @premell @IndianBoy42 @lucc @rohanorton