Skip to content

testGithubActions#10

Open
nvdaes wants to merge 79 commits intomasterfrom
testGithubActions
Open

testGithubActions#10
nvdaes wants to merge 79 commits intomasterfrom
testGithubActions

Conversation

@nvdaes
Copy link
Copy Markdown
Owner

@nvdaes nvdaes commented Feb 28, 2025

  • Set nvdaLauncherFile as env variable
  • Rename appveyor to ci, and restore original appveyor scripts
  • Run workflow on githubActions branch and tags
  • Fix syntax
  • Use double quotes to specify tags
  • Remove tags filter to run when pushing any tag
  • Run all tests
  • Fix path to unit tests
  • Add steps summary
  • License check
  • Fix paths
  • Remove lint
  • Permission to write contents
  • Try to save license check file
  • Test running licensecheck from ps1 invoking bat with cmd
  • Add more step summaries
  • Get job summary on failure
  • Push artifacts
  • Fix workflow
  • Fix workflow syntax
  • Fix syntax
  • Fix workflow
  • Comment on failure
  • Don't run multiple workflows for the same branch
  • Fix path to download NVDA
  • Add link to download test results
  • Don't compress system tests
  • Fix pullRequestNumber env variable
  • Remove md file
  • Make tests to fail

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 1, 2025

PASS: License check.
PASS: System tests (tags: installer NVDA).
FAIL: Translation comments check. Translation comments missing or unexpectedly included. See build log for more information.
FAIL: Unit tests. See test results for more information.

Download test results

@nvdaes nvdaes force-pushed the master branch 2 times, most recently from 84a71c0 to 0035a9f Compare March 5, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant