Skip to content

Add m4#33

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
LeonarddeR:m4
Jun 11, 2024
Merged

Add m4#33
seanbudd merged 1 commit into
nvaccess:masterfrom
LeonarddeR:m4

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Bundle m4 with miscdeps to compile liblouis tables containing macros. See also nvaccess/nvda#16652
cc @codeofdusk

@codeofdusk

Copy link
Copy Markdown

@LeonarddeR Could you please also create a PR against my liblouis-3.30 branch to update the sconstruct with the necessary commands to build the new tables?

@LeonarddeR

LeonarddeR commented Jun 5, 2024 via email

Copy link
Copy Markdown
Collaborator Author

@LeonarddeR LeonarddeR marked this pull request as ready for review June 6, 2024 11:18
@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

@seanbudd This appears to be working great, so if you could merge this in, @codeofdusk can finish nvaccess/nvda#16652
Note that m4 is gpl v3, I don't think that's problematic? We clearly list the source in the readme.

@seanbudd seanbudd self-requested a review June 7, 2024 07:10

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the file checksums and these appear to be correct

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the file checksums and these appear to be correct

@seanbudd seanbudd merged commit ce8ed21 into nvaccess:master Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants