Fixes for BrailliantB and FreedomScientific#9839
Merged
feerrenrut merged 2 commits intoJun 28, 2019
Merged
Conversation
Collaborator
|
@feerrenrut: Looks like you missed this one. I will change the base branch. |
* Remove writeSize parameter from the call to hwIo.Bulk
* Ensure the HID report type is a byte in the HID onReceive handler
afe5954 to
274c4d0
Compare
feerrenrut
approved these changes
Jun 28, 2019
|
@bramd: Could you please edit the PR description due to documentation reasons. Thanks. |
Contributor
Author
|
@DrSooom I could, but this was just a PR against a Python 3 brailleDisplayDrivers branch to fix some things I found after device testing. So, the changes should be described in the main PR. Tha being said, I'll update the description for people who find this PR and wonder what it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains Python 3 fixes for the FreedomScientific and BrailliantB braille drivers found after testing with devices.