Ensure scratchpad dirs exist before adding them to module paths#9814
Merged
Conversation
… create them if they don't already exist.
josephsl
approved these changes
Jun 26, 2019
josephsl
left a comment
Contributor
There was a problem hiding this comment.
Yep, system tests passes. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9797
Replaces pr #9800
Summary of the issue:
System tests fail due to NVDA failing to start because an exception is raised in appModuleHandler.doesAppModuleExist.
The system tests enable NVDA's scratchpad dir, in order to load a globalPlugin and synthDriver. However, it does not necessarily create other scratchpad directories (such as appModules).
It seems that pkgutil.iter_imports emits a None object in place of any path in a module's
__path__that does not physically exist.Although when creating the scratchpad dir from the GUI NVDA automatically creates the needed directories, it does not handle the situation where the scratchpad option has been enabled through some other way. NVDA should always ensure that the directories exist before adding them to a module's paths.
Description of how this pull request fixes the issue:
config.addConfigDirsToPythonPackagePath now creates any subdirs before adding them to the module's
__path__if they do not exist already.Testing performed:
NVDA no longer fails to start if launched with the scratchpad option enabled but missing one or more subdirs in the scratchpad directory.
Known issues with pull request:
None.
Change log entry:
None.