Ensure NVDA contains a signed and valid python37.dll#9796
Merged
michaelDCurran merged 2 commits intothreshold_py3_stagingfrom Jun 24, 2019
Merged
Ensure NVDA contains a signed and valid python37.dll#9796michaelDCurran merged 2 commits intothreshold_py3_stagingfrom
michaelDCurran merged 2 commits intothreshold_py3_stagingfrom
Conversation
…l into dist as Py2exe currently corrupts the dll's certificate by trying to add a string resource.
LeonarddeR
approved these changes
Jun 24, 2019
sconstruct
Outdated
| action.append(buildCmd) | ||
|
|
||
| # Python3 has started signing its main python dll. | ||
| # However, Pytexe currently tries to add a string resource to it, invalidating the signature and possibly currupting the certificate. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9762
Summary of the issue:
On threshold_py3_staging, NVDA fails to sign a side-loadable appx Windows store package of NVDA.
The reason for this is that makeappx detects that python37.dll (included in the package) has a corrupt certificate.
It seems that when Py2exe copies python37.dll into NVDA's dist directory, it tries to add a string resource to the file. this not only invalidates the signature, but also seems to corrupt the certificate and truncate the file.
I think that in Python2.7 python27.dll was never signed, so this was not really an issue. But in Python3, python37.dll is now signed.
Description of how this pull request fixes the issue:
After running py2exe, sconstruct copies a fresh version of python37.dll into dist that has not been tampered with by py2exe.
Testing performed:
Known issues with pull request:
this p works around the issue. Obviously it would be good to know hy py2exe needs to add that string resource to the file.
Change log entry:
None.