UI Automation in Windows Console: remove the isTyping logic from UIA consoles#9673
Merged
Merged
Conversation
This makes autoread work with more console programs at the cost of a few typed characters possibly being echoed/doubled.
264697c to
9414605
Compare
Contributor
Author
Contributor
Author
|
@michaelDCurran Mind having another look at this? |
michaelDCurran
requested changes
Jun 17, 2019
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
Looks like the liblouis submodule has accidentally been updated to a different commit.
Contributor
Author
|
@michaelDCurran Did this fix it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Builds on #9614.
Summary of the issue:
Currently, in UIA consoles:
winConsoleUIA._isTypingis cleared), reporting of new text and speak typed words may not function correctly.Description of how this pull request fixes the issue:
This PR removes the
_isTypingcheck from consoles. Instead:LiveTextobjects strip spaces when filtering typed characters from new text.Testing performed:
On Windows 10 1903, with "speak typed words" and UIA in consoles enabled:
git log.Before this change: NVDA says "qgit".
After this change: NVDA says "git".
Known issues with pull request:
When typing quickly, a few typed characters may bypass the filter, resulting in doubled or incorrectly echoed characters. A more severe form of this issue also occurs in legacy consoles. We might want to filter more aggressively at the risk of missing some new text.
Change log entry:
None.