Windows 10 Mail: catch COM error thrown when Mail app dies and tree interceptor/alive method is attempted#9392
Merged
Merged
Conversation
…nterceptor alive method is attempted. Re nvaccess#9341. Consider the following: a Windows 10 user opens Mail app (hxoutlook), opens a message, then exits Mail app. At that point, tree interceptor/alive method is attempted, but because parent is gone, it raises COM error. Without catching this, NVDA goes silent, so catch this error if possible.
michaelDCurran
approved these changes
Mar 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9341
Summary of the issue:
When Windows 10 Mail app dies, NVDA goes silent due to unhandled COM error.
Description of how this pull request fixes the issue:
When walking up to parent in Mail app's Word document tree interceptor, catch COM error if the parent is gone (noticeable when Mail app dies).
Testing performed:
Tested with an implementation in Windows 10 App Essentials add-on:
Known issues with pull request:
None
Change log entry:
Bug fixes:
NVDA will no longer become silent after exiting Windows 10 Mail app. (#9341)
Thanks.