Skip to content

Fixed "list" is reported on every line of a list in Chrome rich text editors#9382

Closed
awalvie wants to merge 2 commits into
nvaccess:masterfrom
awalvie:i7562
Closed

Fixed "list" is reported on every line of a list in Chrome rich text editors#9382
awalvie wants to merge 2 commits into
nvaccess:masterfrom
awalvie:i7562

Conversation

@awalvie

@awalvie awalvie commented Mar 17, 2019

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #7562

Summary of the issue:

contentEditable list currently does not test for read-only state. In some text rich editors Lists and list boxes both get the same role (list) but what differentiates them is the read-only state. For example to read

Before 
* a
* b
After

It should read

list  bullet  a
bullet  b
out of list  After

it may read

list  bullet  a
list  bullet  b
After

Fully described here

Description of how this pull request fixes the issue:

Currently the Textinfo.getPresentationCategory function returns self.PRESCAT_SINGLELINE when we focus on lists with multiple <ul>. I have removed the condition that returns PRESCAT_SINGLELINE and replaced it in the condition that returns PRESCAT_CONTAINER.

Testing performed:

Replicated the issue and it works as it is supposed to.

@awalvie awalvie changed the title Added a condition as recommended in the issue. Fix for issue #7562 Mar 17, 2019
@dpy013

This comment has been minimized.

@awalvie

This comment has been minimized.

@LeonarddeR LeonarddeR changed the title Fix for issue #7562 Fixed "list" is reported on every line of a list in Chrome rich text editors Mar 21, 2019
@LeonarddeR

This comment has been minimized.

@awalvie

This comment has been minimized.

@awalvie

This comment has been minimized.

@michaelDCurran

michaelDCurran commented Mar 28, 2019

Copy link
Copy Markdown
Member

This breaks the announcement of <select> lists with size>=2 E.g. (paste this "data-url" into your address bar):

data:text/html,<p>Before</p><select size="2"><option>Frogs</option><option>Birds</option></select><p>after</p>

When arrowing down through the document in browse mode, Normally NVDA would say:

before
list clickable frogs
after

But now it says:

Before
list clickable Frogs
out of list
after

I believe that the rule to return single line in getPresentationCategory should still mention list, but only if it does not have the readonly or editable states.
So rather than removing that rule completely, also check to ensure it does not have the editable state.
In the end:

  • lists with no readonly or editable state (E.g. select with size>=2) should be singleline
  • ul lists in a contenteditable should be container
  • read-only ul lists should be container

edits
Improved formatting, explained data url.

@awalvie

awalvie commented Mar 30, 2019

Copy link
Copy Markdown
Contributor Author

Got it will try to implement that too.

@LeonarddeR

Copy link
Copy Markdown
Collaborator

@awalvie: Have you made the requested changes yet?

@awalvie

awalvie commented Apr 25, 2019 via email

Copy link
Copy Markdown
Contributor Author

@Adriani90

Copy link
Copy Markdown
Collaborator

@awalvie any updates on this?

@feerrenrut feerrenrut added the Abandoned requested reports or updates are missing since more than 1 year, author or users are not available. label Jul 10, 2020
@michaelDCurran

Copy link
Copy Markdown
Member

As there are edge cases this pr does not successfully cover, and because Google has filed a bug against Chrome to probably address this in Chrome: https://crbug.com/1087551
We will close this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Abandoned requested reports or updates are missing since more than 1 year, author or users are not available. app/chrome bug ux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chrome: "list" is reported on every line of a list in rich text editors

6 participants