Fixed "list" is reported on every line of a list in Chrome rich text editors#9382
Fixed "list" is reported on every line of a list in Chrome rich text editors#9382awalvie wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This breaks the announcement of When arrowing down through the document in browse mode, Normally NVDA would say: But now it says: I believe that the rule to return single line in
edits |
|
Got it will try to implement that too. |
|
@awalvie: Have you made the requested changes yet? |
|
I am really sorry for not being able to make the suggested changes, I am
currently busy with submissions I am supposed to make at my college which
will then be followed up with exams. I'll try my best to get this fixed as
soon as possible.
…On Thu, Apr 25, 2019, 10:42 Leonard de Ruijter ***@***.***> wrote:
@awalvie <https://github.com/Awalvie>: Have you made the requested
changes yet?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9382 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIQVTPRKY3OTYBICVOILGRLPSE4TTANCNFSM4G7BUIRA>
.
|
|
@awalvie any updates on this? |
|
As there are edge cases this pr does not successfully cover, and because Google has filed a bug against Chrome to probably address this in Chrome: https://crbug.com/1087551 |
Link to issue number:
Fixes #7562
Summary of the issue:
contentEditable list currently does not test for read-only state. In some text rich editors Lists and list boxes both get the same role (list) but what differentiates them is the read-only state. For example to read
It should read
it may read
Fully described here
Description of how this pull request fixes the issue:
Currently the
Textinfo.getPresentationCategoryfunction returnsself.PRESCAT_SINGLELINEwhen we focus on lists with multiple<ul>. I have removed the condition that returnsPRESCAT_SINGLELINEand replaced it in the condition that returnsPRESCAT_CONTAINER.Testing performed:
Replicated the issue and it works as it is supposed to.