Miranda NG: update autoread implementation for new versions of the client#9367
Merged
Conversation
LeonarddeR
approved these changes
Mar 12, 2019
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Just one comment regarding the copyright header
Co-Authored-By: codeofdusk <codeofdusk@gmail.com>
Contributor
Author
|
Done. Any suggestions for fixing the failing test cases? |
Collaborator
|
That's not a problem on your end and will be dealt with as part of #9358 |
| #appModules/miranda32.py | ||
| #A part of NonVisual Desktop Access (NVDA) | ||
| #Copyright (C) 2006-2012 NVDA Contributors | ||
| #Copyright (C) 2006-2019 NV Access Limited, Aleksey Sadovoy, Peter Vágner, Joseph Lee, Bill Dengler |
Member
There was a problem hiding this comment.
Just curious, but how did you work out that Aleksey Sadovoy, Peter Vágner and Joseph Lee contributed to this file? Did you look at the repository history?
Collaborator
|
To find out all the contributors, I ran a git blame over the whole file.
|
michaelDCurran
approved these changes
Mar 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9053
Summary of the issue:
For the past several versions of Miranda NG, NVDA's message autoread support has been broken.
Description of how this pull request fixes the issue:
New versions of the client seem to use a different
windowControlIDfor the scrollbar in the message window. This pull request updates theMESSAGEVIEWERSconstant in the app module to account for this change.Testing performed:
Sent several test messages to the #flood IRC channel on Freenode. Reading was functional but inconsistent (as expected).
Known issues with pull request:
NVDA's autoread support is highly fragile and only functions intermitantly, see #1471.
Change log entry:
== New Features ==