Skip to content

No longer call setlocale from nvda launcher, rely on languageHandler instead #9323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelDCurran merged 3 commits into from
Mar 28, 2019
Merged

No longer call setlocale from nvda launcher, rely on languageHandler instead #9323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c771916
No longer call setlocale at NVDA start, rather rely on the languageHa…
Feb 25, 2019
c346b95
Merge branch 'master' into HEAD
michaelDCurran Mar 28, 2019
9dbc951
Update what's new.
michaelDCurran Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions source/nvda.pyw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,8 @@ import ctypes
import locale
import gettext

#Localization settings
locale.setlocale(locale.LC_ALL,'')
try:
gettext.translation('nvda',localedir='locale',languages=[locale.getlocale()[0]]).install(True)
gettext.translation('nvda',localedir='locale',languages=[locale.getdefaultlocale()[0]]).install(True)
except:
gettext.install('nvda',unicode=True)

Expand Down
3 changes: 1 addition & 2 deletions source/nvda_slave.pyw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ Performs miscellaneous tasks which need to be performed in a separate process.
import gettext
import locale
#Localization settings
locale.setlocale(locale.LC_ALL,'')
try:
gettext.translation('nvda',localedir='locale',languages=[locale.getlocale()[0]]).install(True)
gettext.translation('nvda',localedir='locale',languages=[locale.getdefaultlocale()[0]]).install(True)
except:
gettext.install('nvda',unicode=True)

Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ What's New in NVDA
- LTR and RTL marks are no longer reported in Braille or per-character speech when accessing the properties window. (#8361)
- When jumping to form fields with Browse Mode quick navigation, the entire form field is now announced rather than just the first line. (#9388)
- NVDA will no longer become silent after exiting the Windows 10 Mail app. (#9341)
- NVDA no longer fails to start when the users regional settings are set to a locale unknown to NVDA, such as English (Netherlands). (#8726)


= 2019.1 =
Expand Down