Fixing incorrect text reporting when hovering mouse over Scintilla controls.#9233
Conversation
|
Hi DataTriny Thank you for your contribution I will test it later in the Chinese environment. |
LeonarddeR
left a comment
There was a problem hiding this comment.
Thanks for taking this
|
hi |
|
Thanks @dingpengyu for the tip! |
|
|
Actually the delay is mostly my fault as I didn't see the review comments immediately (thanks GitHub notifications). |
|
@LeonarddeR changes are requested from you. Is that still correct? |
LeonarddeR
left a comment
There was a problem hiding this comment.
Sorry, I missed the fixes to this. It's now ok, go ahead :)
|
@michaelDCurran: Please change the milestone from 2019.1 to 2019.2. Thanks. |
Link to issue number:
Fixes #5450.
Summary of the issue:
When hovering the mouse over Notepad++ text editor, and over any Scintilla control in general, NVDA fails to report the line below the mouse cursor.
Description of how this pull request fixes the issue:
Converts from screen coordinates to client coordinates, in
ScintillaTextInfo._getOffsetFromPoint, so that we can get accurate text offset.Testing performed:
Created a text file containing several lines in Notepad++, hovered the mouse over each line and checked that the reported text was right. Tested both with Notepad++'s window in full screen, maximized as well as in a smaller size.
Known issues with pull request:
None
Change log entry:
Bug fixes