Stop the Virtualbox>=5.2 main window from freezing#9211
Merged
Conversation
michaelDCurran
approved these changes
Jan 31, 2019
|
Why is not this pr merged into master? Do you need approval from other developers? |
Member
|
After I updated changes.t2t it seems that appveyor never built the pr. And then I simply forgot about it. I have just merged master again, and if this builds okay I will merge this to master. Thanks for reminding me :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Related to #9209
Fixes #9202
Summary of the issue:
Virtualbox 5.2 and above freeze in their mainwindow when NVDA is active. The accessibility implementation of the list of VMs is broken. When NVDA tries to get the active child in the list, child.next keeps on returning the same child over and over again, resulting into an endless loop.
Description of how this pull request fixes the issue:
Testing performed:
Tested and confirmed that Virtualbox 6.0.0 no longer freezes.
Known issues with pull request:
I'm not sure whether the first approach (i.e. firstChild.next, etc.) has been chosen on purpose in the past. In the current situation, it is ok to loop through the children, however I"m afraid that this might cause regressions in other places. Therefore, this code might be more complex than necessary.
Change log entry: