NVDAObjects/UIA: treat looping selectors as combo boxes without value pattern#9113
Merged
Merged
Conversation
Remove duplicated 'import time'. When importing Edge, use relative import to make it Python 3 compliant.
…bo boxes without value pattern. Re nvaccess#5231. Looping selectors are used to select an item from values that wraps around, especially employed in time pickers 9SEttings, Alarms and Clock and others). Becasue they do not expose values, treat them as combo box without value pattern objects. This then allows NVDA to ask UIA to fetch the selected value by querying the selected element.
Contributor
Author
|
Hi, I asked mick for a review because he is the one who have investigated combo boxes without value pattern before and knows what might be happening. Also, if he doesn't mind, a second look from @jcsteh is appreciated. Thanks. |
LeonarddeR
approved these changes
Dec 31, 2018
michaelDCurran
approved these changes
Jan 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Finally resolving it after three years:
Link to issue number:
Fixes #5231
Summary of the issue:
Looping selectors do not expose value pattern, causing NVDA to not announce currently selected item. This is prominent in Alarms and Clock app and other apps where time picker is involved.
Description of how this pull request fixes the issue:
Looping selectors without value pattern is coerced into NVDAObjects.UIA.ComboBoxWithouValuePattern.
Testing performed:
Tested with Alarms and Clock, Settings and other apps employing time pickers on various Windows 10 releases (builds 17134, 17763, 18305)
Known issues with pull request:
None
Change log entry:
Bug fixes: I advise copying the what's new entry for ComboBoxWithoutValuePattern fix (#6337), adopting the wording to say that the fix now applies to certain time pickers in Windows 10 apps.
Thanks.