Baum braille displays: fix broken input when no model identifier is set for a display#8951
Merged
Conversation
Collaborator
Author
|
@michaelDCurran: Could you please review this for 2018.4? |
michaelDCurran
approved these changes
Nov 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8894
Summary of the issue:
Some Baum braille displays, such as the Vario 40, seem to provide no model identifier. The current baum driver requires a model identifier to execute gestures.
Description of how this pull request fixes the issue:
Allow creating gesture objects without a model identifier.
Testing performed:
Tests performed by @nishimotz erikpro
Known issues with pull request:
None
Change log entry: