Add support for Foxit Reader and Foxit PhantomPDF (#8944)#8947
Merged
Conversation
LeonarddeR
suggested changes
Nov 15, 2018
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this great work!
Contributor
Author
|
@LeonarddeR Thanks for the review. |
LeonarddeR
approved these changes
Nov 15, 2018
Collaborator
|
@gauldoth: Will this do or break anything when using version 9.2 or older? |
Contributor
|
Hi, Congratulations on the first contribution. Can we get a second look from @michaelDCurran or someone at NV Access please? Footnote: this code is compatible with Python 3. Thanks. |
Contributor
Author
@LeonarddeR It won't. If the window class name "FoxitDocWnd" is detected, the MSAA and PDDom interface is available. |
michaelDCurran
approved these changes
Nov 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #8944
Summary of the issue:
It is currently not possible to read PDF files in Foxit Reader.
Foxit Reader has implemented MSAA and PDF Dom interface in version 9.3.
The UIA implementation is not complete yet. Out of process queries are quite slow due to some unknown reasons. But their developers have implemented both MSAA and PDDom for the document, the UIA implementation may be removed in future releases.
Foxit PhantomPDF exposed the same interface as Foxit Reader did.
Description of how this pull request fixes the issue:
Use Adobe Acrobat code to make Foxit Reader accessible.
Ignore Foxit Reader's UIA implementation.
Testing performed:
Tested with Foxit Reader 9.3 and Foxit PhantomPDF 9.3 by me.
Tested with several PDF documents and PDF forms by me.
The guys from Foxit have tested against NVDA for a few weeks.
Known issues with pull request:
None
Change log entry:
Section: New features