Gecko vbufBackend: If a table row is invalidated, it should not require its parent to be updated#8833
Merged
Merged
Conversation
…re its parent to be updated. this is not logically needed, and caused a major performance hit on gmail.
jcsteh
approved these changes
Oct 10, 2018
| // Thus, ensuring we rerender this node's parent, gives a chance to rerender other table rows. | ||
| LOG_DEBUG(L"Setting node's requiresParentUpdate to true"); | ||
| parentNode->requiresParentUpdate=true; | ||
| // Note that we however do not want to set this on table rows as if this row alone is invalidated, none of the other row coodinates would be affected. |
Contributor
There was a problem hiding this comment.
typo: coodinates -> coordinates
Collaborator
|
Last week, I was playing with a pretty complex corporate web application, which unfortunately isn't public. This application had a table that changed as soon as you selected some criteria and pressed a search button. However, the changes in the table weren't reflected in browse mode, I had to refresh the virtual buffer in order for the new cells to show up. Table navigation was broken as well. This wasn't a problem with NVDA 2018.3.2. Unfortunately, I don't know of a way to reproduce this. Creating a simple html table with a button beneath it that magically adds a row or a cell within a row works correctly (i.e. it does not trigger this behavior). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
The work to speed up dynamic updates in virtualBuffers in pr #8678 causes a major slowdown in the new Gmail interface.
Specifically:
When arrowing up and down the message list, a cell on one of the rows is changed in such a way that in Gecko its accessible is re-framed and therefore the row itself is marked in the virtualBuffer as being invalid. But as row nodes in the Gecko vbufBackend have their requiresParentUpdate property set to true, this causes the entire table to be re-rendered.
The comment where this property is set specifically talks about row groups needing this, not rows. But the code does not correctly exclude rows.
As we know that other row coordinates will not change just because a row was invalidated, it would be safe to exclude rows from having their requiresParentUpdate property set to true.
Description of how this pull request fixes the issue:
This PR only sets requiresParentUpdate to true on nodes within tables that are not cells or rows. (In otherwords, probably just row groups).
Testing performed:
Known issues with pull request:
None.
Change log entry:
None.