Second attempt to update to configobj 5.1.0dev#8626
Merged
Conversation
Contributor
|
Hi, I would like to propose that this be merged once 2018.4 development is in full swing due to risks involved. Thanks.
|
Contributor
|
@josephsl the beta branch will no longer be getting merges from master, so one can consider 2018.4 development to be underway. |
feerrenrut
approved these changes
Aug 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #4470
Implements #7945
Supersedes #8622
Summary of the issue:
The previous attempt to update configobj did not really update to the new configobj, but was accidentally still using the configobj from misc-deps.
Description of how this pull request fixes the issue:
This time, we really updated to configobj 5.1.0dev.
Testing performed:
As @feerrenrut proposed earlier, testing should include an upgrade path of an old config file without a schema version from NVDA 2016.4 or older. These are the results.
Known issues with pull request:
NOne
Change log entry:
Included in changes.t2t