Skip to content

Second attempt to update to configobj 5.1.0dev#8626

Merged
feerrenrut merged 4 commits into
nvaccess:masterfrom
LeonarddeR:configobj
Aug 14, 2018
Merged

Second attempt to update to configobj 5.1.0dev#8626
feerrenrut merged 4 commits into
nvaccess:masterfrom
LeonarddeR:configobj

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Aug 13, 2018

Copy link
Copy Markdown
Collaborator

Link to issue number:

Closes #4470
Implements #7945
Supersedes #8622

Summary of the issue:

The previous attempt to update configobj did not really update to the new configobj, but was accidentally still using the configobj from misc-deps.

Description of how this pull request fixes the issue:

This time, we really updated to configobj 5.1.0dev.

  1. I added logging to the core module that will print the configobj and validate versions.
  2. validate is now considered a part of the configobj package. Add-ons should use configobj.validate instead of validate directly.
  3. To facilitate a smooth upgrade path, I added a validate.py module to NVDA's source tree that imports configobj.validate.*. It will also raise a proper deprecation warning, like this:
C:\Users\Leonard de Ruijter\AppData\Roaming\nvda\addons\vocalizer_expressive_driver\synthDrivers\vocalizer_expressive\_config.py:11: DeprecationWarning: Importing validate directly is deprecated. Please use configobj.validate instead
  from validate import Validator

Testing performed:

As @feerrenrut proposed earlier, testing should include an upgrade path of an old config file without a schema version from NVDA 2016.4 or older. These are the results.

Known issues with pull request:

NOne

Change log entry:

Included in changes.t2t

@LeonarddeR LeonarddeR requested a review from feerrenrut August 13, 2018 13:51
@josephsl

josephsl commented Aug 13, 2018 via email

Copy link
Copy Markdown
Contributor

@feerrenrut

Copy link
Copy Markdown
Contributor

@josephsl the beta branch will no longer be getting merges from master, so one can consider 2018.4 development to be underway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to ConfigObj 5.x.y

4 participants