Treat documents as being multiline in Braille#8569
Merged
Conversation
…tInfo region is hard left on the display.
dkager
previously approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8406
Summary of the issue:
Multiline text fields in braille should appear hard left on the braille display to allow as much room as possible for the content of the first line.
NVDA already does this for terminals, and anything with the multiline state. However, it does not do it for documents.
This is now a noticeable problem when using UI automation in MS Word, where the controlType for the UIA element for the document is in deed document. When previously using the object model, it was edit, but did have the multiline state.
Description of how this pull request fixes the issue:
Braille now treats documents as being multiline.
Testing performed:
Using NVDA with braille:
Known issues with pull request:
None.
Change log entry:
Bug fixes: