Fix a case where the "not checked" state is not reported in speech#8550
Merged
Conversation
…sn't for REASON_CHANGE Fixes nvaccess#6946
Collaborator
|
@Andre9642 commented on 24 jul. 2018 11:46 CEST:
It looks like you're not doing an additional check for the presence of checked in your code. |
Contributor
Author
My bad. That's true. Although it seems to work like this too... |
michaelDCurran
approved these changes
Jul 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #6946
Summary of the issue:
In a specific context, NVDA doesn't report the "not checked" state.
Description of how this pull request fixes the issue:
In
controlTypes.pythenprocessNegativeStates()function, for REASON_CHANGE, if HALFCHECKED is present but CHECKED isn't, we add CHECKED to speakNegatives.Testing performed:
Tested with examples provided in #6946 comments and other HTML code. Works for me.
Known issues with pull request:
None known.
Change log entry:
Section: Bug fixes