Fix broken gesture identifier in freedomscientific driver#7716
Merged
Conversation
added 2 commits
November 1, 2017 11:11
…rovide a unit test to make this happen no more in the future. This also changes braille.getDisplayList to allow getting a full list of displays, ignoring the result of every check function.
…ForIdentifier, as this prevents the input gestures dialog from launching. Note that this should never happen for core drivers, as a unit test should take care of this
Collaborator
Author
|
@michaelDCurran: this is a regression in master that should be fixed before 2017.4, if possible. |
michaelDCurran
approved these changes
Nov 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #7713.
Summary of the issue:
When the Freedom Scientific driver is active, the input gestures dialog can't be launched in Master due to braille.BrailleDisplayGesture.getDisplayTextForIdentifier raising a ValueError. It turned out one of the identifiers in the freedomScientific driver was malformed, having the br(freedomscientific] prefix.
Description of how this pull request fixes the issue:
Testing performed:
Ran the new unit test against the broken freedomScientific driver, it cached the mistake properly.
Known issues with pull request:
None
Change log entry: