Skip to content

Fix broken gesture identifier in freedomscientific driver#7716

Merged
michaelDCurran merged 2 commits into
nvaccess:masterfrom
LeonarddeR:checkGestureMaps
Nov 1, 2017
Merged

Fix broken gesture identifier in freedomscientific driver#7716
michaelDCurran merged 2 commits into
nvaccess:masterfrom
LeonarddeR:checkGestureMaps

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Nov 1, 2017

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixes #7713.

Summary of the issue:

When the Freedom Scientific driver is active, the input gestures dialog can't be launched in Master due to braille.BrailleDisplayGesture.getDisplayTextForIdentifier raising a ValueError. It turned out one of the identifiers in the freedomScientific driver was malformed, having the br(freedomscientific] prefix.

Description of how this pull request fixes the issue:

  1. Fixed the malformed identifier in the freedomScientific driver
  2. Provided a unit test that checks every display driver gesture map for possible malformed identifiers.
  3. Added a keyword arg excludeNegativeChecks to braille.getDisplayList in order to list all braille display drivers, not only those that passed the check.
  4. Stopped braille.BrailleDisplayGesture.getDisplayTextForIdentifier from raising a ValueError. instead, an error is logged and the identifier is returned with the prefix "malformed:"

Testing performed:

Ran the new unit test against the broken freedomScientific driver, it cached the mistake properly.

Known issues with pull request:

None

Change log entry:

Leonard de Ruijter added 2 commits November 1, 2017 11:11
…rovide a unit test to make this happen no more in the future.

This also changes braille.getDisplayList to allow getting a full list of displays, ignoring the result of every check function.
…ForIdentifier, as this prevents the input gestures dialog from launching. Note that this should never happen for core drivers, as a unit test should take care of this
@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

@michaelDCurran: this is a regression in master that should be fixed before 2017.4, if possible.

@michaelDCurran michaelDCurran merged commit 7a3ab02 into nvaccess:master Nov 1, 2017
@nvaccessAuto nvaccessAuto added this to the 2017.4 milestone Nov 1, 2017
@LeonarddeR LeonarddeR deleted the checkGestureMaps branch August 23, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't activate Input Gestures Dialog with Focus40 Blue Braille Display

3 participants