Add a bunch of extension points to eliminate NVDA Remote monkey patching#7594
Closed
LeonarddeR wants to merge 2 commits into
Closed
Add a bunch of extension points to eliminate NVDA Remote monkey patching#7594LeonarddeR wants to merge 2 commits into
LeonarddeR wants to merge 2 commits into
Conversation
Collaborator
Author
|
Keeping this open for reference, but holding this back for review requests until #7599 is merged. |
Contributor
added 2 commits
September 29, 2018 13:35
* inputCore.manager.decide_executeGesture: Decider for filtering gestures * tones.decide_beep * nvwave.decide_playWaveFile
…er as well as filter and process the cells written to a braille display
Collaborator
Author
|
Closing this for now, since this is still a work in progress and relies on speech refactor. I might reopen or file an entirely new pr later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None. Some discussion around #7484 (comment) though
Summary of the issue:
NVDA Remote requires monkey patching to be notified of several actions on a controlled system (e.g. selecting a braille display or playing beeps).
Description of how this pull request fixes the issue:
Implemented the following extension points:
Known issues with pull request:
This is not yet complete as there are no extension points for speech. However, this is intentional as this awaits #4877.