Add ConsoleWindowClass to badUIAWindowClasses as the UIA implementation for win32 Console windows is not usable yet.#7497
Merged
Conversation
…on for win32 Console windows is not usable yet.
jcsteh
approved these changes
Aug 15, 2017
jcsteh
left a comment
Contributor
There was a problem hiding this comment.
I know the rest of the entries in this list don't have comments, but I think it'd be good to have a brief comment here (and for future entries) stating why it was added; i.e. why this implementation is problematic for us.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
In Windows 10 build 16257, Microsoft introduced a UIA implementation for Win32 console windows. Not only does this conflict with our existing support, their UIA implementation is not yet complete (I.e. caret support is lacking, and most likely no useful events for new text).
As this implementation will be in the Fall Creaters update released before NVDA 2017.4, we should for now ignore this UIA implementation, and revisit how we should handle it properly if the implementation improves.
Description of how this pull request fixes the issue:
ConsoleWindowClass is added to _UIAHandler.badUIAWindowClasses.
Testing performed:
All of these tests showed NVDA functioning the way it used to before the new UIA implementation in 16257.
Known issues with pull request:
None.
Change log entry:
Probably none needed as getting this in 2017.3 before the general public notice would be good.