Add landmark property to the base NVDAObject#7493
Merged
Merged
Conversation
Collaborator
|
this fixes the issue. |
michaelDCurran
approved these changes
Aug 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #7490
Summary of the issue:
Regression from #7328, sometimes an error is raised while navigating through a document in Edge, for example a PDF document.
Description of how this pull request fixes the issue:
Adds the landmark property added in #7328 to the base NVDAObject, so getting the landmark property from an object always returns something.
Testing performed:
@derekriemer: Could you please double check whether this fixes the PDF issue you reported?
Known issues with pull request:
None I'm aware of
Change log entry:
None, regression from 2017.2.
@michaelDCurran, since this is a regression from 2017.2, I think this is best merged into master after @derekriemer confirms that it fixes the issue.