Move sounds and images from miscDeps into the NVDA repository itself#7462
Merged
Conversation
… since they're specific to NVDA (not dependencies) and are quite small.
Merged
feerrenrut
approved these changes
Aug 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None specifically. However, this is required for #7446; see below.
Summary of the issue:
We've made (or considered) several updates to media lately, including the new suggestion open/close sounds (#6241), the new default sounds (#7218, although we decided not to go ahead with this) and the new icon (#7446). It's likely there will be more such updates in future. Updating miscDeps for these cases is tedious and error prone. Furthermore, sounds and images are specific to NVDA (i.e. they aren't dependencies) and are quite small, so having them in miscDeps doesn't make a great deal of sense.
Description of how this pull request fixes the issue:
Testing performed:
Known issues with pull request:
None.
Change log entry:
None needed; related only to the repositories.
Merge notes:
We want to merge this straight to master: