Skip to content

Move sounds and images from miscDeps into the NVDA repository itself#7462

Merged
feerrenrut merged 1 commit into
masterfrom
moveMedia
Aug 1, 2017
Merged

Move sounds and images from miscDeps into the NVDA repository itself#7462
feerrenrut merged 1 commit into
masterfrom
moveMedia

Conversation

@jcsteh

@jcsteh jcsteh commented Aug 1, 2017

Copy link
Copy Markdown
Contributor

Link to issue number:

None specifically. However, this is required for #7446; see below.

Summary of the issue:

We've made (or considered) several updates to media lately, including the new suggestion open/close sounds (#6241), the new default sounds (#7218, although we decided not to go ahead with this) and the new icon (#7446). It's likely there will be more such updates in future. Updating miscDeps for these cases is tedious and error prone. Furthermore, sounds and images are specific to NVDA (i.e. they aren't dependencies) and are quite small, so having them in miscDeps doesn't make a great deal of sense.

Description of how this pull request fixes the issue:

  1. Adds source/waves and source/images to the NVDA repo.
  2. Removes them from miscDeps.

Testing performed:

  1. Ran locally and confirmed that sounds play.
  2. This is pretty much the same change as Replace NVDA's start, exit, error, browse mode and focus mode sounds #7218, except with the old sounds instead of the proposed new ones. That change has been incubating on next for weeks with no problems.

Known issues with pull request:

None.

Change log entry:

None needed; related only to the repositories.

Merge notes:

We want to merge this straight to master:

  1. For Update NVDA Icon #7446, we want to put the icon into the NVDA repo instead of miscDeps, so Update NVDA Icon #7446 depends on this work. We want to get Update NVDA Icon #7446 into 2017.3, so this needs to be done ASAP.
  2. This is pretty much the same change as Replace NVDA's start, exit, error, browse mode and focus mode sounds #7218, except with the old sounds instead of the proposed new ones. That change has been incubating on next for weeks with no problems.

… since they're specific to NVDA (not dependencies) and are quite small.
@jcsteh jcsteh requested a review from feerrenrut August 1, 2017 02:22
@jcsteh jcsteh mentioned this pull request Aug 1, 2017
@feerrenrut feerrenrut merged commit 2c818d0 into master Aug 1, 2017
@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Aug 1, 2017
@feerrenrut feerrenrut deleted the moveMedia branch August 1, 2017 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants