Skip to content

Restore Bangla symbol file#20246

Merged
seanbudd merged 5 commits into
nvaccess:betafrom
CyrilleB79:restoreBnSymb
Jun 9, 2026
Merged

Restore Bangla symbol file#20246
seanbudd merged 5 commits into
nvaccess:betafrom
CyrilleB79:restoreBnSymb

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented May 29, 2026

Copy link
Copy Markdown
Contributor

Link to issue number:

Discussed in this thread.

Fix-up of #19766

Summary of the issue:

In #19766, the Bangla symbol file was removed because it was almost exclusively in English. As a result, punctuation reporting falls back to CLDR.

However, Bangla user prefers English symbol names than CLDR which seems excessively verbose.

Description of user facing changes:

Restored 2025.3.3 Bangla symbol file since it has proven to be useful accross many releases.

Description of developer facing changes:

N/A

Description of development approach:

  1. Bangla symbol file restored to last version before it was deleted in Remove empty Bangla translation #19766.
  2. Only other change:
    • Fixed double space in ". sentence ending" symbol name which was preventing it to be used
    • and updated its replacement as per NVDA users list discussion

Testing strategy:

Manual test for characters ' (tick), - (dash) and ". sentence ending" complex symbol.

Known issues with pull request:

This PR only restores 2025.3.3 state + adds an obvious fix.

This file should probably be translated further and maybe updated. But this is the job of a Bangla translator that I am not at all. And for now, there isn't actually any NVDA Bangla translator.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jun 1, 2026
@CyrilleB79 CyrilleB79 marked this pull request as ready for review June 4, 2026 07:30
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner June 4, 2026 07:30
@CyrilleB79 CyrilleB79 requested a review from SaschaCowley June 4, 2026 07:30
@seanbudd seanbudd added this to the 2026.2 milestone Jun 9, 2026
Comment thread source/locale/bn/symbols.dic Outdated
@seanbudd seanbudd merged commit a0c7791 into nvaccess:beta Jun 9, 2026
6 checks passed
@CyrilleB79 CyrilleB79 deleted the restoreBnSymb branch June 9, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants