Make system restart the secondary action in the post-update dialog to avoid potential data loss and maintain user expectations#20171
Merged
Conversation
… avoid potential data loss
Member
|
Thanks @codeofdusk - just need to confirm with the team we want this going into beta branch |
seanbudd
approved these changes
May 21, 2026
Member
|
@codeofdusk - can you please fix up the translator comment issue |
Member
|
Why was this approach taken, rather than looking into the underlying reason a forced shutdown is being initiated? Rather than calling |
Member
|
@SaschaCowley - good point. Are you going to open a PR/issue for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#19718 (comment)
Summary of the issue:
The "restart Windows" action is primary (invokes with Enter) in the update dialog. This is a sudden change in behaviour which is likely to surprise long-time NVDA users. Generally, destructive actions like this (that can lead to loss of unsaved data or similar) are secondary in UIs.
Description of how this pull request fixes the issue:
Mark the new restart action as secondary in the dialog, preserving default behaviour.
Testing strategy:
Alpha/beta testing.
Known issues with pull request:
None known
Code Review Checklist: