Skip to content

Beta to master#19798

Merged
SaschaCowley merged 6 commits into
masterfrom
beta
Mar 17, 2026
Merged

Beta to master#19798
SaschaCowley merged 6 commits into
masterfrom
beta

Conversation

@SaschaCowley

Copy link
Copy Markdown
Member

No description provided.

CyrilleB79 and others added 6 commits March 16, 2026 13:53
Summary of the issue:

A deprecation message recommended to use gui.messageDialog.MessageDialog but the gui.message module does not exist.
Description of user facing changes:

The deprecation message will now mention gui.message.MessageDialog.
Description of developer facing changes:

Fixed both the deprecation message and docstrings mentioning the non-existing gui.messageDialog module.
This pull request updates translations to languages being tracked from
Crowdin.

Co-authored-by: GitHub Actions <github-actions@github.com>
Merged translations from Crowdin
Spawned from #19740 

### Summary of the issue:
It was hard to track all the different places language codes are
normalized in NVDA.

### Description of developer facing changes:


This pull request standardizes language code formatting across the NVDA
codebase by introducing and using the `toXmlLang` and `toNvdaLang`
utility functions from `speechXml`. This ensures consistent handling of
language codes (e.g., converting between underscores and hyphens) when
interacting with speech synthesis engines and related components.


### Description of development approach:
Replaced manual string manipulation for language codes (such as
`replace("_", "-")` or `replace("-", "_")`) with the use of `toXmlLang`
and `toNvdaLang` utility functions in `speech.py`, `_espeak.py`,
`espeak.py`, and `oneCore.py` to ensure consistent formatting for speech
engine interoperability.
This pull request refactors type annotations and import statements in
`source/gui/settingsDialogs.py` to use modern Python type hinting syntax
and improve import organization. The changes primarily involve replacing
`typing` module type hints with built-in generic types, as well as
reordering some import statements for clarity.
@SaschaCowley SaschaCowley requested a review from a team as a code owner March 17, 2026 05:53
@SaschaCowley SaschaCowley requested a review from seanbudd March 17, 2026 05:53
@SaschaCowley SaschaCowley merged commit 1ff5b3b into master Mar 17, 2026
10 of 11 checks passed
@github-actions github-actions Bot added this to the 2026.2 milestone Mar 17, 2026
@github-actions github-actions Bot requested a deployment to snapshot March 17, 2026 06:40 Abandoned
@github-actions github-actions Bot requested a deployment to production March 18, 2026 02:00 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants