Beta to master#19798
Merged
Merged
Conversation
Summary of the issue: A deprecation message recommended to use gui.messageDialog.MessageDialog but the gui.message module does not exist. Description of user facing changes: The deprecation message will now mention gui.message.MessageDialog. Description of developer facing changes: Fixed both the deprecation message and docstrings mentioning the non-existing gui.messageDialog module.
This pull request updates translations to languages being tracked from Crowdin. Co-authored-by: GitHub Actions <github-actions@github.com>
Merged translations from Crowdin
Spawned from #19740 ### Summary of the issue: It was hard to track all the different places language codes are normalized in NVDA. ### Description of developer facing changes: This pull request standardizes language code formatting across the NVDA codebase by introducing and using the `toXmlLang` and `toNvdaLang` utility functions from `speechXml`. This ensures consistent handling of language codes (e.g., converting between underscores and hyphens) when interacting with speech synthesis engines and related components. ### Description of development approach: Replaced manual string manipulation for language codes (such as `replace("_", "-")` or `replace("-", "_")`) with the use of `toXmlLang` and `toNvdaLang` utility functions in `speech.py`, `_espeak.py`, `espeak.py`, and `oneCore.py` to ensure consistent formatting for speech engine interoperability.
This pull request refactors type annotations and import statements in `source/gui/settingsDialogs.py` to use modern Python type hinting syntax and improve import organization. The changes primarily involve replacing `typing` module type hints with built-in generic types, as well as reordering some import statements for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.