Magnifier - Small User Guide formatting#19769
Merged
Merged
Conversation
Contributor
Author
|
Not for NV Access: If we are willing to begin using bold formatting (or other types of formatting) in translated markdown, let's state it explicitely and let's discuss in which situation such formatting is accepted or even desirable. In this case, I'll close this PR (or restrict it to list merging). Also cc @Boumtchack FYI, so that you can figure NV Access position for your future work. |
seanbudd
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
In Magnifier documentation: bold is used at some places.
Such formatting has not been used until now in the User Guide, so we'd better be consistent here. It probably does not bring so much information for blind users who usually have not font attribute reporting enabled (speech / braille). Also worth noting that such formatting had been removed from NVDA remote documentatation when it has been integrated in NVDA's user guide. At last such formatting makes the translators work a bit harder, so if it's not necessary, let's not use it.
Also, a list is unwantedly split in two parts.
Description of user facing changes:
Description of developer facing changes:
N/A
Description of development approach:
See diff
Testing strategy:
Check the generated User Guide.
Known issues with pull request:
None
Code Review Checklist: