Skip to content

Update Liblouis to 3.37.0#19758

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
codeofdusk:liblouis-3.37
Mar 10, 2026
Merged

Update Liblouis to 3.37.0#19758
seanbudd merged 1 commit into
nvaccess:masterfrom
codeofdusk:liblouis-3.37

Conversation

@codeofdusk

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

Liblouis 3.37.0 was released.

Description of how this pull request fixes the issue:

Update LibLouis.

Testing strategy:

Alpha testing.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@codeofdusk codeofdusk requested a review from a team as a code owner March 8, 2026 00:01
@codeofdusk codeofdusk requested review from Copilot and seanbudd March 8, 2026 00:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates NVDA’s Liblouis dependency to 3.37.0 and reflects related Braille table/documentation changes.

Changes:

  • Bumped Liblouis submodule to 3.37.0.
  • Added an Estonian 6-dot table registration and adjusted the Italian 6-dot table display name.
  • Updated user/dev documentation to mention the Liblouis update and table changes.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
user_docs/en/changes.md Documents the Liblouis update and mentions new/updated tables.
source/brailleTables/__tables.py Registers Estonian 6-dot table and changes Italian 6-dot table label shown in UI.
projectDocs/dev/createDevEnvironment.md Updates the documented Liblouis version used for dev environment setup.
include/liblouis Updates the Liblouis git submodule commit pointer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread user_docs/en/changes.md
Comment thread source/brailleTables/__tables.py
Comment thread projectDocs/dev/createDevEnvironment.md
@zstanecic

Copy link
Copy Markdown
Contributor

@LeonarddeR and @codeofdusk
Before merging this, can you add new/renamed braille tables? There is also improved italian.

@codeofdusk

Copy link
Copy Markdown
Contributor Author

@LeonarddeR and @codeofdusk Before merging this, can you add new/renamed braille tables? There is also improved italian.

I renamed the Italian table in __tables.py, is there another table that needs to be added?

@zstanecic

Copy link
Copy Markdown
Contributor

Okay @codeofdusk,
In that case, if you have renamed italian, All is ok.
Have a nice day,
Zvonimir

@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 10, 2026

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codeofdusk

@seanbudd seanbudd merged commit f239666 into nvaccess:master Mar 10, 2026
41 of 45 checks passed
@github-actions github-actions Bot added this to the 2026.2 milestone Mar 10, 2026
@seanbudd

Copy link
Copy Markdown
Member

Did this happen to fix #18110?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants